Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix format time on arrival time column #7623

Merged
merged 1 commit into from
Jun 13, 2024
Merged

front: fix format time on arrival time column #7623

merged 1 commit into from
Jun 13, 2024

Conversation

Uriel-Sautron
Copy link
Contributor

  • disable stop time column for orign and destination
  • disable receotion on close signal column for orign
  • add step attribute to arrival time column input

close #7619

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner June 5, 2024 13:24
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 28.47%. Comparing base (1e88977) to head (5bd83ce).
Report is 1 commits behind head on dev.

Files Patch % Lines
...ont/src/modules/timesStops/TimeColumnComponent.tsx 0.00% 16 Missing and 1 partial ⚠️
front/src/modules/timesStops/TimesStops.tsx 0.00% 16 Missing ⚠️
...rationalStudies/views/v2/ManageTrainScheduleV2.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7623      +/-   ##
============================================
- Coverage     28.48%   28.47%   -0.02%     
  Complexity     2038     2038              
============================================
  Files          1243     1243              
  Lines        153360   153384      +24     
  Branches       3008     3008              
============================================
- Hits          43682    43669      -13     
- Misses       107887   107924      +37     
  Partials       1791     1791
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 71.87% <ø> (-0.05%) ⬇️
front 9.83% <0.00%> (-0.01%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Yohh
Yohh approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@Uriel-Sautron Uriel-Sautron force-pushed the usn/format-arrival-time branch from efed424 to a796457 Compare June 5, 2024 15:24
achrafmohye
achrafmohye approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Uriel-Sautron Uriel-Sautron force-pushed the usn/format-arrival-time branch 6 times, most recently from 7071985 to 2d8be8f Compare June 7, 2024 12:17
SharglutDev
SharglutDev requested changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, left some comments.

As it changes various things on the TimesStops component, maybe it would have been better to have one commit for each fonctionnality fixed or added.

front/src/modules/timesStops/TimeColumnComponent.tsx Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
@Uriel-Sautron Uriel-Sautron force-pushed the usn/format-arrival-time branch from 2d8be8f to 37b2b79 Compare June 13, 2024 08:15
kmer2016
kmer2016 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget to squash

SharglutDev
SharglutDev reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job ! Waiting for commis cleaning to approve

@Uriel-Sautron Uriel-Sautron force-pushed the usn/format-arrival-time branch from 37b2b79 to 6d7cb30 Compare June 13, 2024 09:06
@Uriel-Sautron
front: fix timesstop component
5bd83ce 
  - disable stop time column for origin and destination
  - add seconds in arrival time column
  - disable reception on close signal column for origin
  - add step attribute to arrival time column input
  - add no path loaded message
  - fix strange behavior when typing seconds in arrival time column
@Uriel-Sautron Uriel-Sautron force-pushed the usn/format-arrival-time branch from 6d7cb30 to 5bd83ce Compare June 13, 2024 10:10
@SharglutDev SharglutDev enabled auto-merge June 13, 2024 10:14
@SharglutDev SharglutDev added this pull request to the merge queue Jun 13, 2024
Merged via the queue into dev with commit aa7652d Jun 13, 2024
17 checks passed
@SharglutDev SharglutDev deleted the usn/format-arrival-time branch June 13, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@achrafmohye achrafmohye achrafmohye approved these changes

@Yohh Yohh Yohh approved these changes

@kmer2016 kmer2016 kmer2016 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSv2: Times and stops tab arrival time column does not support seconds
6 participants
@Uriel-Sautron @codecov-commenter @kmer2016 @Yohh @achrafmohye @SharglutDev